Better messaging on notebook fail #10056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
commented
Feb 11, 2020
| @@ -71,18 +71,18 @@ export class InteractivePanel extends React.Component<IInteractivePanelProps> { | |||
| <section id="main-panel-variable" aria-label={getLocString('DataScience.collapseVariableExplorerLabel', 'Variables')}> | |||
| {this.renderVariablePanel(this.props.baseTheme)} | |||
| </section> | |||
| <main id="main-panel-content" onClick={this.contentPanelClick} onScroll={this.handleScroll}> | |||
| <main id="main-panel-content" onScroll={this.handleScroll}> | |||
There was a problem hiding this comment.
Small change related to @DonJayamanne feedback on this PR:
#10029
I'm worried catching all clicks on the main panel is too aggressive. Don already noted that you now can't handle selecting sys info text to copy out. So instead moved it over to the footer. This had the nice benefit of greatly expanding the click area for the input box there. Previously you had to click just on the editor, which is close to the footer BG color. Now the entire footer can be clicked to focus the input.
DavidKutu
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #10056 +/- ##
=========================================
Coverage ? 61.23%
=========================================
Files ? 565
Lines ? 30200
Branches ? 4568
=========================================
Hits ? 18494
Misses ? 10673
Partials ? 1033
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Feb 11, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
pushed a commit
that referenced
this pull request
Feb 15, 2020
rchiodo
added a commit
that referenced
this pull request
Feb 18, 2020
* Better messaging on notebook fail (#10056) * Install jupyter instead of installing kernel spec (#10080) * Install jupyter instead of installing kernel spec For #10071 * Eliminate variable value when computing data frame info (#10081) * Fix ndarray types to be viewable again (#10093) * Eliminate variable value when computing data frame info * Fix ndarrays to work again Add test to make sure we don't regress this again * Rchiodo/kernel telemetry (#10115) * Add duration to select local/remote kernel * Add notebook language telemetry * Add news entries * #9883 telemetry * News entry * Another spot for kernel spec failure * Add telemetry on product install * Fix install telemetry * Undo launch.json change * Handle other cases * Better way to handle case * Wrong event for jupyter install * Fix unit tests * Clear variables when restarting regardless if visible or not (#10117) * Use different method for checking if kernelspec is available (#10114) * Use different method for checking if kernelspec is available * Fix unit tests * More logging for kernelspec problems (#10132) * More logging for kernelspec problems * Actually capture the exception on the new code * Not actually using output if first exception still there. * Actually only return output on one of the expected calls. * Fix nightly flake * Check our saved jupyter interpreters before allowing any of them to be used as active interpreters (#10113) * Update changelog and package.json * Missing part of changelog * Fix tests and linter problems Co-authored-by: Ian Huff <[email protected]> Co-authored-by: Don Jayamanne <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9904
Note. I was not able to repro the situation where I was failing and didn't see the missing dependencies popup. When I deleted or removed jupyter from the saved jupyter interpreter I always got the missing dependencies popup. So I added the target interpreter to that dialog (so the user can see what they are trying to use) and improved the help link.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).