Skip to content

Bump plotly.js-dist at v1.56.0 #14183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Bump plotly.js-dist at v1.56.0 #14183

merged 1 commit into from
Oct 2, 2020

Conversation

archmoj
Copy link

@archmoj archmoj commented Sep 30, 2020

Bumping plotly.js-dist module now that plotly.js v1.56.0 is out https://github.com/plotly/plotly.js/releases/tag/v1.56.0

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

Similar to PR #13828
Also FYI a PR is submitted to nteract/outputs#22.

@rchiodo
cc: @nicolaskruchten

@rchiodo rchiodo self-assigned this Sep 30, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #14183 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14183      +/-   ##
==========================================
- Coverage   59.95%   59.95%   -0.01%     
==========================================
  Files         706      706              
  Lines       39135    39135              
  Branches     5674     5674              
==========================================
- Hits        23463    23462       -1     
- Misses      14437    14438       +1     
  Partials     1235     1235              
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411d1d4...ea96c4b. Read the comment docs.

@archmoj
Copy link
Author

archmoj commented Oct 2, 2020

Would you mind adding skip news tag so that the test pass?
Thanks!

@rchiodo rchiodo added the no-changelog No news entry required label Oct 2, 2020
@rchiodo rchiodo merged commit 80894e4 into microsoft:main Oct 2, 2020
@archmoj archmoj mentioned this pull request Oct 15, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants