-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bump plotly.js-dist v1.57.1 #14413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plotly.js-dist v1.57.1 #14413
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14413 +/- ##
==========================================
- Coverage 59.40% 59.19% -0.22%
==========================================
Files 716 720 +4
Lines 39999 40211 +212
Branches 5793 5829 +36
==========================================
+ Hits 23763 23802 +39
- Misses 14975 15147 +172
- Partials 1261 1262 +1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed!
|
@rchiodo would you mind reviewing this PR? |
Thanks @rchiodo for the review. |
You should be able to resolve them in this PR. |
Just rebase or merge with main and push the change again. |
I don't understand why |
Hi @archmoj, We're really sorry for the inconvenience and want to minimize the delay for changes you're working on. However, we are in the end stages of a restructuring to enable a more manageable relationship with the Python core extension's codebase. We're getting very close to having this completed and once we do we will make a more public statement about it. Please stay tuned. |
Hi @greazer, is there a place I find more information on this restructuring and timelines? Our concern is that the plotly python module requires an up to date version of Plotly.js to be available in VSCode-python for notebook users to have a good experience with our new features :) |
This needs to be ported to the new source. |
@rchiodo we'd be happy to! Where is the new source? |
Sorry that's not public yet. Should be soon. I'll comment here when it's possible to move it to the new location. |
It seems like the right place to do this now (or at least an additional place to do it!) is here https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1812 @archmoj can you please submit the equivalent PR there for 1.57.1, and continue to do so there from now on? |
|
Bumping
plotly.js-dist
module now thatplotly.js
v1.57.1
is outhttps://github.com/plotly/plotly.js/releases/tag/v1.57.0
https://github.com/plotly/plotly.js/releases/tag/v1.57.1
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).Similar to PR #14183
Also FYI a PR is submitted to nteract/outputs#24 and nteract/outputs#28.
@rchiodo
cc: @nicolaskruchten