Skip to content

Bump plotly.js-dist v1.57.1 #14413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump plotly.js-dist v1.57.1 #14413

wants to merge 2 commits into from

Conversation

archmoj
Copy link

@archmoj archmoj commented Oct 15, 2020

Bumping plotly.js-dist module now that plotly.js v1.57.1 is out
https://github.com/plotly/plotly.js/releases/tag/v1.57.0
https://github.com/plotly/plotly.js/releases/tag/v1.57.1

  • skip news
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

Similar to PR #14183
Also FYI a PR is submitted to nteract/outputs#24 and nteract/outputs#28.

@rchiodo
cc: @nicolaskruchten

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #14413 into main will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14413      +/-   ##
==========================================
- Coverage   59.40%   59.19%   -0.22%     
==========================================
  Files         716      720       +4     
  Lines       39999    40211     +212     
  Branches     5793     5829      +36     
==========================================
+ Hits        23763    23802      +39     
- Misses      14975    15147     +172     
- Partials     1261     1262       +1     
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.92% <0.00%> (-1.21%) ⬇️
...ience/interactive-common/interactiveWindowTypes.ts 100.00% <0.00%> (ø)
...atascience/interactive-common/dataViewerChecker.ts 20.83% <0.00%> (ø)
...data-viewing/jupyterVariableDataProviderFactory.ts 50.00% <0.00%> (ø)
...ient/datascience/data-viewing/dataViewerFactory.ts 28.57% <0.00%> (ø)
...rc/client/datascience/jupyter/debuggerVariables.ts 8.21% <0.00%> (ø)
src/client/datascience/constants.ts 99.79% <0.00%> (+<0.01%) ⬆️
src/client/datascience/commands/commandRegistry.ts 34.53% <0.00%> (+0.02%) ⬆️
.../datascience/interactive-common/interactiveBase.ts 5.93% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e6e28...cb01d9b. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@archmoj archmoj changed the title Bump plotly.js-dist v1.57.0 Bump plotly.js-dist v1.57.1 Oct 20, 2020
@archmoj
Copy link
Author

archmoj commented Oct 27, 2020

@rchiodo would you mind reviewing this PR?
Thank you!

@archmoj
Copy link
Author

archmoj commented Oct 27, 2020

Thanks @rchiodo for the review.
Concerning those merge conflicts, would you possibly resolve that? Or if you want me to open a new PR?

@rchiodo
Copy link

rchiodo commented Oct 27, 2020

You should be able to resolve them in this PR.

@rchiodo
Copy link

rchiodo commented Oct 27, 2020

Just rebase or merge with main and push the change again.

@archmoj
Copy link
Author

archmoj commented Oct 27, 2020

Just rebase or merge with main and push the change again.

I don't understand why plotly.js is now removed from dependencies on the main branch after #14447.
@rchiodo @nicolaskruchten could you please have a look?

@greazer
Copy link
Member

greazer commented Oct 27, 2020

Hi @archmoj, We're really sorry for the inconvenience and want to minimize the delay for changes you're working on. However, we are in the end stages of a restructuring to enable a more manageable relationship with the Python core extension's codebase. We're getting very close to having this completed and once we do we will make a more public statement about it. Please stay tuned.

@nicolaskruchten
Copy link

Hi @greazer, is there a place I find more information on this restructuring and timelines?

Our concern is that the plotly python module requires an up to date version of Plotly.js to be available in VSCode-python for notebook users to have a good experience with our new features :)

@rchiodo
Copy link

rchiodo commented Nov 10, 2020

This needs to be ported to the new source.

@nicolaskruchten
Copy link

@rchiodo we'd be happy to! Where is the new source?

@rchiodo
Copy link

rchiodo commented Nov 11, 2020

Sorry that's not public yet. Should be soon. I'll comment here when it's possible to move it to the new location.

@nicolaskruchten
Copy link

It seems like the right place to do this now (or at least an additional place to do it!) is here https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1812

@archmoj can you please submit the equivalent PR there for 1.57.1, and continue to do so there from now on?

@archmoj
Copy link
Author

archmoj commented Nov 12, 2020

It seems like the right place to do this now (or at least an additional place to do it!) is here https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1812

@archmoj can you please submit the equivalent PR there for 1.57.1, and continue to do so there from now on?

@nicolaskruchten Done in microsoft/vscode-jupyter#1083.

@archmoj archmoj closed this Nov 12, 2020
@archmoj archmoj deleted the plotly.js-v1.57.0 branch November 12, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants