Skip to content

Use options object in terminal methods #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2020

Conversation

DonJayamanne
Copy link

For #8928
Next PR will resolve requirements of #8928
(this PR focuses on some refactoring)

  • Passing args as object instead of individual args

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 23, 2020
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #9739 into master will decrease coverage by 0.02%.
The diff coverage is 79.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9739      +/-   ##
==========================================
- Coverage   60.65%   60.62%   -0.03%     
==========================================
  Files         552      552              
  Lines       29778    29792      +14     
  Branches     4505     4518      +13     
==========================================
+ Hits        18061    18062       +1     
- Misses      10706    10710       +4     
- Partials     1011     1020       +9
Impacted Files Coverage Δ
src/client/common/variables/types.ts 100% <ø> (ø) ⬆️
src/client/common/terminal/types.ts 100% <ø> (ø) ⬆️
src/client/common/terminal/helper.ts 94.52% <100%> (ø) ⬆️
src/client/common/terminal/syncTerminalService.ts 82.35% <100%> (+0.21%) ⬆️
src/client/terminals/activation.ts 83.33% <100%> (ø) ⬆️
src/client/common/utils/misc.ts 68.42% <100%> (+11.27%) ⬆️
src/client/providers/terminalProvider.ts 100% <100%> (ø) ⬆️
src/client/common/terminal/activator/index.ts 83.33% <100%> (ø) ⬆️
...t/common/variables/environmentVariablesProvider.ts 90% <100%> (+0.29%) ⬆️
src/client/common/terminal/activator/base.ts 77.27% <40%> (-9.1%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9481f1...db61915. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit f862978 into microsoft:master Jan 23, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
@DonJayamanne DonJayamanne deleted the refactorTermArgs branch February 5, 2020 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants