Skip to content

Use a terminal to get environment variables of an activated interpreter #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 24, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jan 23, 2020

For #8928
To be reviewed after #9739

@DonJayamanne
Copy link
Author

Typical CI

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #9744 into master will increase coverage by 0.12%.
The diff coverage is 91.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9744      +/-   ##
==========================================
+ Coverage   60.58%   60.71%   +0.12%     
==========================================
  Files         552      556       +4     
  Lines       29860    29972     +112     
  Branches     4529     4546      +17     
==========================================
+ Hits        18092    18198     +106     
+ Misses      10750    10748       -2     
- Partials     1018     1026       +8
Impacted Files Coverage Δ
src/client/common/terminal/types.ts 100% <ø> (ø) ⬆️
src/client/telemetry/index.ts 85.58% <ø> (ø) ⬆️
src/client/common/terminal/factory.ts 82.85% <0%> (-2.44%) ⬇️
src/client/datascience/preWarmVariables.ts 100% <100%> (ø)
src/client/interpreter/activation/service.ts 86.95% <100%> (+2.02%) ⬆️
...activation/terminalEnvironmentActivationService.ts 100% <100%> (ø)
src/client/common/constants.ts 100% <100%> (ø) ⬆️
.../client/interpreter/activation/preWarmVariables.ts 100% <100%> (ø)
src/client/terminals/activation.ts 84.21% <100%> (+0.87%) ⬆️
src/client/common/experimentGroups.ts 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6707d6...2050926. Read the comment docs.

@rchiodo
Copy link

rchiodo commented Jan 23, 2020

export class InMemoryInterpreterSpecificCache {

Could this one derive from the new one you made? Looks pretty similar.


Refers to: src/client/common/utils/cacheUtils.ts:81 in ae7ca3c. [](commit_id = ae7ca3c, deletion_comment = False)

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@DonJayamanne
Copy link
Author

Could this one derive from the new one you made? Looks pretty similar.

@rchiodo Yes, but that would complicate it. Hence choose not to
Right now both use different caching providers. Also, one is specific to interpreters and other is a general caching class.

@rchiodo
Copy link

rchiodo commented Jan 23, 2020

Okay then how bout a common base class.


In reply to: 577929350 [](ancestors = 577929350)

@DonJayamanne
Copy link
Author

DonJayamanne commented Jan 24, 2020

Okay then how bout a common base class.

@rchiodo
Good suggestion, cleaned up.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit d788d18 into microsoft:master Jan 24, 2020
@DonJayamanne DonJayamanne deleted the issue8928 branch January 24, 2020 17:44
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants