feat: suggest the config connection string on connect failure #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
reviewed
Apr 14, 2025
| return { | ||
| content: [{ type: "text", text: `Successfully connected to ${connectionString}.` }], | ||
| }; | ||
| } catch (error) { |
There was a problem hiding this comment.
nit: alternatively you can override handleError here
There was a problem hiding this comment.
Unfortunately, it's a bit more complicated since I wanted to have the extra check comparing the connection string we tried connecting to to the connection string in the config. handleError right now doesn't supply the original args used to invoke the tool and even if it did, in the case of connecting by cluster name, we wouldn't know what the resolved connection string is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has a configured connection string and the connect fails (e.g. due to the model infering an incorrect connection string from the code), suggest using the config connection string instead.
Fixes #73