fix: tweak the connect tool to prefer preconfigured connection string #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14594832497Details
💛 - Coveralls |
nirinchev
force-pushed
the
ni/integration-delete
branch
from
74480b3 to
14d74e7
Compare
nirinchev
force-pushed
the
ni/connect-tweaks
branch
from
e578ece to
c871c9f
Compare
… preconfigured connection string
nirinchev
force-pushed
the
ni/connect-tweaks
branch
from
c871c9f to
f2f9e65
Compare
gagik
approved these changes
Apr 22, 2025
| type: "string", | ||
| name: "options", | ||
| description: | ||
| "Options for connecting to MongoDB. If not provided, the connection string from the config://connection-string resource will be used. If the user hasn't specified Atlas cluster name or a connection string explicitly and the `config://connection-string` resource is present, always invoke this with no arguments.", |
There was a problem hiding this comment.
out of curiosity, does this work well in practice? I'm afraid this may be specific to models being used though don't have a better solution for this either.
There was a problem hiding this comment.
When I tested it, it seemed to work well with Claude, Cursor, and Windsurf, though would be nice if others can verify it works as expected in their setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80