Skip to content

PYTHON-4287: Support Creation of Multiple Vector Search Indexes for Database Generation Step #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 24, 2024
Merged

PYTHON-4287: Support Creation of Multiple Vector Search Indexes for Database Generation Step #12

merged 9 commits into from
Apr 24, 2024

Conversation

Jibola
Copy link
Collaborator

@Jibola Jibola commented Mar 28, 2024

Support multiple index creation for our AI-ML testing pipeline

@Jibola Jibola requested a review from caseyclements March 28, 2024 17:24
caseyclements
caseyclements requested changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests for this feature. We need tests of the testing framework itself.

Jibola
Jibola commented Apr 23, 2024
View reviewed changes
@Jibola
Copy link
Collaborator Author

Jibola commented Apr 23, 2024

There are no tests for this feature. We need tests of the testing framework itself.

I agree here. I'm thinking we should make this a separate task seeing as there's quite a bit that would need tests.

@Jibola Jibola requested a review from caseyclements April 23, 2024 17:45
@Jibola Jibola mentioned this pull request Apr 23, 2024
Merged
2 tasks
@Jibola Jibola changed the title PTYHON-4287: Multi index support PTYHON-4287: Support Creation of Multiple Vector Search Indexes for Pipeline Apr 23, 2024
@Jibola Jibola changed the title PTYHON-4287: Support Creation of Multiple Vector Search Indexes for Pipeline PTYHON-4287: Support Creation of Multiple Vector Search Indexes for Database Generation Step Apr 23, 2024
@caseyclements caseyclements changed the title PTYHON-4287: Support Creation of Multiple Vector Search Indexes for Database Generation Step PYTHON-4287: Support Creation of Multiple Vector Search Indexes for Database Generation Step Apr 23, 2024
caseyclements
caseyclements requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keen to get this one merged, as docarray needs this.

@Jibola Jibola requested a review from caseyclements April 24, 2024 18:56
caseyclements
caseyclements approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jibola Jibola merged commit 66ca46f into main Apr 24, 2024
@Jibola Jibola deleted the multi-index-support branch April 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyclements caseyclements caseyclements approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jibola @caseyclements