PYTHON-4134: Update LangChain test to run langchain-mongodb partner package rather than community #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
previously requested changes
Mar 11, 2024
Jibola
changed the title
caseyclements
requested changes
Apr 24, 2024
| @@ -7,21 +7,15 @@ set -x | |||
|
|
|||
| PYTHON_BINARY=$(find_python3) | |||
|
|
|||
| cd libs/langchain | |||
| cd libs/partners/mongodb | |||
|
|
|||
| $PYTHON_BINARY -m venv . | |||
There was a problem hiding this comment.
This is not the recommended way to use poetry. You don't want to use venv. Look at the implementation in llama_index/run.sh for an example. chatgpt does the same. There are comments explaining what is happening on each line.
There was a problem hiding this comment.
Ah yeah, I think the one thing about that is the evergreen urges not "writing outside of the directory" which is what I interpreted a pip install with the binary to be under that general umbrella.
There was a problem hiding this comment.
Ah. You're right. Using a venv will keep all in one place. Hmmm. Maybe I should update the others...
caseyclements
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our LangChain tests have evolved immensely. The largest change stems from test running in their own partner library langchain-mongodb. As a result, we are dropping our support/maintenance of the langchain-community package version and are wholesale supporting our new langchain-mongodb partner package. The goal of this PR is to now run the langchain-mongodb test suite