Skip to content

DOCSP-33943: mention dns seedlist default tls setting #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Oct 31, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33943
Staging - Enable TLS/SSL

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@ccho-mongodb ccho-mongodb marked this pull request as ready for review October 31, 2023 19:06
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion + 1 issue, then LGTM

.. note::

If you connect by using the DNS seedlist protocol, indicated by the ``+srv``
connection string modifier, the driver enables TLS/SSL. To disable it,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Compound adjective

Suggested change
connection string modifier, the driver enables TLS/SSL. To disable it,
connection-string modifier, the driver enables TLS/SSL. To disable it,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I had intended to keep it consistent with the Server manual mention (linked in the PR text), but I think it could be more clear to describe a little differently.


If you connect by using the DNS seedlist protocol, indicated by the ``+srv``
connection string modifier, the driver enables TLS/SSL. To disable it,
set the ``tls`` or ``ssl`` parameter value to ``false`` it in your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I:

Suggested change
set the ``tls`` or ``ssl`` parameter value to ``false`` it in your
set the ``tls`` or ``ssl`` parameter value to ``false`` in your

@ccho-mongodb ccho-mongodb merged commit f7ac2f8 into mongodb:master Nov 1, 2023
@ccho-mongodb ccho-mongodb deleted the DOCSP-33943-tls-when-using-seedlist branch November 1, 2023 00:28
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
ccho-mongodb pushed a commit that referenced this pull request Nov 1, 2023
* DOCSP-33943: mention dns seedlist default tls setting

(cherry picked from commit f7ac2f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants