-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-33943: mention dns seedlist default tls setting #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ccho-mongodb
merged 4 commits into
mongodb:master
from
ccho-mongodb:DOCSP-33943-tls-when-using-seedlist
Nov 1, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -37,6 +37,17 @@ You can enable TLS/SSL for the connection to your MongoDB instance | |||||
in two different ways: through a parameter in your connection string, or | ||||||
using a method in the ``MongoClientSettings.Builder`` class. | ||||||
|
||||||
.. note:: | ||||||
|
||||||
If you connect by using the DNS seedlist protocol, indicated by the ``+srv`` | ||||||
connection string modifier, the driver enables TLS/SSL. To disable it, | ||||||
set the ``tls`` or ``ssl`` parameter value to ``false`` it in your | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I:
Suggested change
|
||||||
connection string or ``MongoClientSettings`` instance. | ||||||
|
||||||
To learn more about connection behavior when you use a DNS seedlist, | ||||||
see the :manual:`SRV Connection Format </reference/connection-string/#std-label-connections-dns-seedlist>` | ||||||
section in the Server manual. | ||||||
|
||||||
.. tabs:: | ||||||
|
||||||
.. tab:: ConnectionString | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Compound adjective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! I had intended to keep it consistent with the Server manual mention (linked in the PR text), but I think it could be more clear to describe a little differently.