DOCSP-34415: improve index #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccho-mongodb
approved these changes
Nov 14, 2023
source/index.txt
Outdated
Comment on lines
40
to
41
| to install the driver by using `Maven <https://maven.apache.org/>`__ or | ||
| `Gradle <https://gradle.org/>`__ in your project and set up a runnable app. |
There was a problem hiding this comment.
Suggestion:
I think "install the driver" could be interpreted as launching an installer and/or having it available for anything, so the following might be more precise:
"learn how to add the driver to your project by using Maven..."
To make the items joined by the conjunction parallel, I think it could be good to include the prepositional phrase:
"and [how] to set up a runnable app"
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
rustagir
added a commit
that referenced
this pull request
Nov 14, 2023
* DOCSP-34415: improve index * CC suggestion (cherry picked from commit c613862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34415
Staging - https://preview-mongodbrustagir.gatsbyjs.io/java/DOCSP-34415-improve-index/#introduction
Self-Review Checklist