Skip to content

[JAVA] Java driver throws exception for asNumber for BsonDecimal128 #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Jan 15, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35118
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/java/docsworker-xlarge/DOCSP-35118/whats-new/#std-label-version-5.0

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@rachel-mack rachel-mack marked this pull request as ready for review January 16, 2024 16:17
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments but dont need to re rev

@@ -54,6 +54,10 @@ The 5.0 driver release introduces the following features:
name, or it defaults to ``MULTIPLE`` if you specify more than one
host.

- ``BsonDecimal128`` values now respond to method calls in the same way as Java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: remove "now" since this is already sorted into a versioned section

Suggested change
- ``BsonDecimal128`` values now respond to method calls in the same way as Java
- ``BsonDecimal128`` values respond to method calls in the same way as Java

Comment on lines 58 to 59
``Decimal128`` values. In particular, ``isNumber()`` and ``asNumber()``
error responses now match the Java responses for equivalent ``Decimal128`` values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``Decimal128`` values. In particular, ``isNumber()`` and ``asNumber()``
error responses now match the Java responses for equivalent ``Decimal128`` values.
``Decimal128`` values. Specifically, the error responses for the ``isNumber()`` and ``asNumber()``
methods match the Java responses for equivalent ``Decimal128`` values.

@rachel-mack rachel-mack merged commit 92d3aff into mongodb:master Jan 16, 2024
@rachel-mack rachel-mack deleted the DOCSP-35118 branch January 16, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants