Skip to content

[JAVA] Java driver throws exception for asNumber for BsonDecimal128 #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

[JAVA] Java driver throws exception for asNumber for BsonDecimal128 #500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70e988f
bsondecimal128 responses match java
rachel-mack Jan 15, 2024
8e0cdf7
RR review
rachel-mack Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/whats-new.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ The 5.0 driver release introduces the following features:
name, or it defaults to ``MULTIPLE`` if you specify more than one
host.

- ``BsonDecimal128`` values now respond to method calls in the same way as Java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: remove "now" since this is already sorted into a versioned section

Suggested change
- ``BsonDecimal128`` values now respond to method calls in the same way as Java
- ``BsonDecimal128`` values respond to method calls in the same way as Java

``Decimal128`` values. In particular, ``isNumber()`` and ``asNumber()``
error responses now match the Java responses for equivalent ``Decimal128`` values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``Decimal128`` values. In particular, ``isNumber()`` and ``asNumber()``
error responses now match the Java responses for equivalent ``Decimal128`` values.
``Decimal128`` values. Specifically, the error responses for the ``isNumber()`` and ``asNumber()``
methods match the Java responses for equivalent ``Decimal128`` values.


.. _version-4.11:

What's New in 4.11
Expand Down