5.0 Removals #510
5.0 Removals #510
Conversation
stIncMale
requested review from
a team,
rozza and
stIncMale
and removed request for
a team and
rozza
There was a problem hiding this comment.
@mongoKart The PR description says that DOCSP-34117 (redirects to https://jira.mongodb.org/browse/CLOUDP-211220) is included here, but that can't be right. Did you mean to specify DOCSP-34317, which is indeed included in this PR?
Yep! Updated. |
| - Changes the data type of the timeout duration parameter in the | ||
| ``SocketSettings.Builder.connectTimeout()`` and ``SocketSettings.Builder.readTimeout()`` | ||
| methods. The data type of this parameter is now ``long`` instead of ``int``. | ||
| To view an | ||
| example that shows how to instantiate a ``SocketSettings`` instance by using | ||
| these methods, see the :ref:`SocketSettings Example | ||
| <java-socketsettings-example>` in the Specify MongoClient Settings | ||
| guide. |
There was a problem hiding this comment.
This text effectively duplicates the text below (search for connectTimeout, readTimeout, java-socketsettings-example). The latter was reviewed in #507.
| - Changes the data type of the timeout duration parameter in the | |
| ``SocketSettings.Builder.connectTimeout()`` and ``SocketSettings.Builder.readTimeout()`` | |
| methods. The data type of this parameter is now ``long`` instead of ``int``. | |
| To view an | |
| example that shows how to instantiate a ``SocketSettings`` instance by using | |
| these methods, see the :ref:`SocketSettings Example | |
| <java-socketsettings-example>` in the Specify MongoClient Settings | |
| guide. |
There was a problem hiding this comment.
Sorry, I'm not seeing the duplicate text; could you specify where it is?
There was a problem hiding this comment.
Apologies, that text wasn't duplicated, it was removed and replaced with the text I quoted originally. The removed text has already been reviewed and updated in #507, more specifically, in the following commit: 7e55ff2.
The fact that this PR does not have those modifications, yet also updates that text suggests that something went wrong (fortunately, Git complains about the conflict in source/upgrade.txt, as expected). Anyway, I am asking to incorporate the changes made in the commit 7e55ff2 to files source/includes/fundamentals/code-snippets/mcs.java and source/upgrade.txt into the current PR (the list below gives an overview of the changes I am talking about, the linked commit contains all of these changes):
- The
Lsuffixes in the example are not needed. - The example does not show how to instantiate
SocketSettings. - We need to inform users that this change breaks binary compatibility.
mongoKart
force-pushed
the
5.0-removals
branch
from
9c38fbd to
61387d4
Compare
| - Changes the data type of the timeout duration parameter in the | ||
| ``SocketSettings.Builder.connectTimeout()`` and ``SocketSettings.Builder.readTimeout()`` | ||
| methods. The data type of this parameter is now ``long`` instead of ``int``. | ||
| To view an | ||
| example that shows how to instantiate a ``SocketSettings`` instance by using | ||
| these methods, see the :ref:`SocketSettings Example | ||
| <java-socketsettings-example>` in the Specify MongoClient Settings | ||
| guide. |
There was a problem hiding this comment.
Apologies, that text wasn't duplicated, it was removed and replaced with the text I quoted originally. The removed text has already been reviewed and updated in #507, more specifically, in the following commit: 7e55ff2.
The fact that this PR does not have those modifications, yet also updates that text suggests that something went wrong (fortunately, Git complains about the conflict in source/upgrade.txt, as expected). Anyway, I am asking to incorporate the changes made in the commit 7e55ff2 to files source/includes/fundamentals/code-snippets/mcs.java and source/upgrade.txt into the current PR (the list below gives an overview of the changes I am talking about, the linked commit contains all of these changes):
- The
Lsuffixes in the example are not needed. - The example does not show how to instantiate
SocketSettings. - We need to inform users that this change breaks binary compatibility.
|
@rachel-mack, could you please close this PR, given that it was superseded by #521? |
|
Replaced by #521 |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34103
JIRA - https://jira.mongodb.org/browse/DOCSP-34106
JIRA - https://jira.mongodb.org/browse/DOCSP-34107
JIRA - https://jira.mongodb.org/browse/DOCSP-34108
JIRA - https://jira.mongodb.org/browse/DOCSP-34104
JIRA - https://jira.mongodb.org/browse/DOCSP-34115
JIRA - https://jira.mongodb.org/browse/DOCSP-34116
JIRA - https://jira.mongodb.org/browse/DOCSP-34317
JIRA - https://jira.mongodb.org/browse/DOCSP-34128
JIRA - https://jira.mongodb.org/browse/DOCSP-34140
Staging - https://preview-mongodbmongokart.gatsbyjs.io/java/5.0-removals/
Self-Review Checklist