-
Notifications
You must be signed in to change notification settings - Fork 43
DOCSP-47041: Causal consistency #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-47041: Causal consistency #623
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small suggestions
source/crud/transactions.txt
Outdated
- The driver runs write operations that logically must precede other write operations | ||
before these dependent writes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a little confusing to me. Would it make sense to simplify it to something like this?
- The driver runs write operations that logically must precede other write operations | |
before these dependent writes. | |
- The driver runs write operations before first when they logically must precede other write operations. |
An example might help make this more clear as well
source/crud/transactions.txt
Outdated
- The driver runs write operations that logically must follow other read operations | ||
after these reads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the above, could this be simplified and/or have an example added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded and added an example, let me know what you think!
source/crud/transactions.txt
Outdated
|
||
MongoDB enables **causal consistency** in client sessions. | ||
The causal consistency model guarantees that operations within a session | ||
run in a causal order. Additionally, clients observe results that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Not sure that "additionally" is necessary here
run in a causal order. Additionally, clients observe results that | |
run in a causal order. Clients observe results that |
source/crud/transactions.txt
Outdated
operations. If you perform a series of operations where one operation | ||
logically depends on the result of another, any subsequent | ||
reads reflect the dependent relationship. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Clarify that this is giving an example of the preceding descriptions
operations. If you perform a series of operations where one operation | |
logically depends on the result of another, any subsequent | |
reads reflect the dependent relationship. | |
operations. For example, if you perform a series of operations where one operation | |
logically depends on the result of another, any subsequent | |
reads reflect the dependent relationship. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@stIncMale this PR doesn't need a tech review; it includes information that applies to all drivers and uses the same copy approved by a Python engineer for PyMongo. |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47041
Staging Links
Self-Review Checklist