Skip to content

DOCSP-46686: Causal consistency #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Feb 26, 2025

Poached from Nora's PR with a couple of method name tweaks.

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46686

Staging Links

  • write/transactions
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 26, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 7e1e9c2
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67bf687475633f000876ea05
    😎 Deploy Preview https://deploy-preview-188--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    Comment on lines 96 to 97
    - Read operations that have a ``MAJORITY`` read concern
    - Write operations that have a ``MAJORITY`` write concern
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: since it looks like you set these to lowercase strings in PyMongo

    Suggested change
    - Read operations that have a ``MAJORITY`` read concern
    - Write operations that have a ``MAJORITY`` write concern
    - Read operations that have a ``"majority"`` read concern
    - Write operations that have a ``"majority"`` write concern

    @mcmorisi mcmorisi requested a review from NoahStapp February 26, 2025 19:26
    @mcmorisi mcmorisi merged commit d922bd6 into mongodb:master Feb 26, 2025
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-46686-causal-consistency branch February 26, 2025 19:37
    mcmorisi added a commit that referenced this pull request Feb 26, 2025
    mcmorisi added a commit that referenced this pull request Feb 26, 2025
    mcmorisi added a commit that referenced this pull request Feb 26, 2025
    mcmorisi added a commit that referenced this pull request Feb 26, 2025
    mcmorisi added a commit that referenced this pull request Feb 26, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants