-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DOCS-1197 document hashed shard keys #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
including fields that hold arrays or sub-documents. | ||
|
||
For fields that hold arrays and sub-documents, you cannot use the index to | ||
support any query that introspects the value of an array or sub-document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't in the hashed index section which means it's probably a bit out of place, and also I thought re: our conversation yesterday, you couldn't use "hashed" index on multi-key fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot create a hashed index on an array.
You can create a hashed index on apparently any other BSON type (so a: {b: {c: {d: 1, e: 2}}} is a valid document for a hashed index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So "for fields that hold arrays" (which would be a multi-key index) is misleading or confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed references to arrays, which I thought I'd done already.
Incorporated review comments from sam
Pushed changes addressing comments. |
I think I addressed your comments, if not let me know. |
I think there a few things in this list that should still be changed. (It's ok to --amend commits in pull request, but then you have to push -f..) |
Am closing this and doing a separate pull request. |
* Update prereqs procedure * tech review feedback * copy and remaining tech review
* Update prereqs procedure * tech review feedback * copy and remaining tech review
* (DOCSP-18180) multi-cluster beta * Initial review, content restructuring * Build warnings removal * Edits, ready for a copy review * Adjust the table of contents * A few more edits * Address copy review round1 from John W * Address 2nd round of copy review * Remove exta bullet where it is not needed * A few more cleanup type edits * A few more nits * Address tech review from Ciprian * Fixed code block indentation in step 2 * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity
* (DOCSP-18180) multi-cluster beta * Initial review, content restructuring * Build warnings removal * Edits, ready for a copy review * Adjust the table of contents * A few more edits * Address copy review round1 from John W * Address 2nd round of copy review * Remove exta bullet where it is not needed * A few more cleanup type edits * A few more nits * Address tech review from Ciprian * Fixed code block indentation in step 2 * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity * Add minor edits to code examples for clarity
Signoff from dan.