Skip to content

ci(NODE-4655): add 18 to CI matrix #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

ci(NODE-4655): add 18 to CI matrix #515

merged 2 commits into from
Sep 26, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 22, 2022 •
edited
Loading

Description

What is changing?

  • a new task is added to CI that runs our tests on Node18
  • tasks now run on ubuntu20
  • @types/node is bumped to the latest version to resolve a Typescript failure (on typescript@next)
  • register-expect was removed in favor of registering expect globally ourselves. it's been a while since I made the change but it was necessary to fix a CI failure when I upgraded to Node18 or ubuntu20
Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson
Copy link
Contributor Author

typescript next tests fail on main too - https://spruce.mongodb.com/version/632dbc832a60ed08c0db8855/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

@baileympearson baileympearson force-pushed the NODE-4655-add-node18-to-ci branch from 7cb1768 to 7070f59 Compare September 23, 2022 17:57
@baileympearson baileympearson changed the title ci: add 18 to CI matrix ci(NODE-4655): add 18 to CI matrix Sep 26, 2022
@baileympearson baileympearson marked this pull request as ready for review September 26, 2022 17:45
@nbbeeken nbbeeken merged commit a93441d into main Sep 26, 2022
@nbbeeken nbbeeken deleted the NODE-4655-add-node18-to-ci branch September 26, 2022 18:14
baileympearson added a commit that referenced this pull request Jun 1, 2023
@baileympearson
ci(NODE-4655): add 18 to CI matrix (#515)
02d5226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @durran @nbbeeken