Skip to content

ci(NODE-4655): add 18 to CI matrix #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2022
Merged

ci(NODE-4655): add 18 to CI matrix #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7070f59
ci: add 18 to CI matrix
baileympearson Sep 22, 2022
808e142
chore: bump node types to latest
baileympearson Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ tasks:
- func: run tests
vars:
TEST_TARGET: node
- name: node-tests-v18
tags: ["node"]
commands:
- func: fetch source
vars:
NODE_MAJOR_VERSION: 18
- func: install dependencies
- func: run tests
vars:
TEST_TARGET: node
- name: browser-tests
tags: ["browser"]
commands:
Expand All @@ -168,14 +178,14 @@ tasks:
commands:
- func: fetch source
vars:
NODE_MAJOR_VERSION: 16
NODE_MAJOR_VERSION: 18
- func: install dependencies
- func: run checks
- name: check-typescript-oldest
commands:
- func: fetch source
vars:
NODE_MAJOR_VERSION: 16
NODE_MAJOR_VERSION: 18
- func: install dependencies
- func: "run typescript"
vars:
Expand All @@ -185,7 +195,7 @@ tasks:
commands:
- func: fetch source
vars:
NODE_MAJOR_VERSION: 16
NODE_MAJOR_VERSION: 18
- func: install dependencies
- func: "run typescript"
vars:
Expand All @@ -195,7 +205,7 @@ tasks:
commands:
- func: fetch source
vars:
NODE_MAJOR_VERSION: 16
NODE_MAJOR_VERSION: 18
- func: install dependencies
- func: "run typescript"
vars:
Expand All @@ -204,16 +214,16 @@ tasks:

buildvariants:
- name: linux
display_name: Ubuntu 18.04
run_on: ubuntu1804-test
display_name: Ubuntu 22.04
run_on: ubuntu2004-small
tasks: [".node", ".browser"]
- name: mac
display_name: MacOS 10.14
run_on: macos-1014
tasks: [".node"]
- name: lint
display_name: lint
run_on: rhel70
run_on: ubuntu2004-small
tasks:
- run-checks
- check-typescript-oldest
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^4.0.0",
"@rollup/plugin-typescript": "^6.0.0",
"@types/node": "^18.0.0",
"@types/node": "^18.7.22",
"@typescript-eslint/eslint-plugin": "^5.30.0",
"@typescript-eslint/parser": "^5.30.0",
"array-includes": "^3.1.3",
Expand Down
1 change: 0 additions & 1 deletion test/mocha.opts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
--require ts-node/register
--require chai/register-expect
--require source-map-support/register
--timeout 10000
2 changes: 1 addition & 1 deletion test/register-bson.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// and make sure you run mocha using our .mocharc.json or with --require ts-node/register

// This should be done by mocha --require, but that isn't supported until mocha version 7+
require('chai/register-expect');
global.expect = require('chai').expect;
require('array-includes/auto');
require('object.entries/auto');
require('array.prototype.flatmap/auto');
Expand Down