Skip to content

test(NODE-5623): use npm 9 on eol node versions #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

test(NODE-5623): use npm 9 on eol node versions #622

merged 1 commit into from
Sep 11, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Sep 8, 2023 •
edited
Loading

Description

Fixes Node 16 failures with npm 10.

What is changing?

  • Installs npm@9 when on Node 16 or lower.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5603

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title test(NODE-5603): use npm 9 on eol node versions test(NODE-5623): use npm 9 on eol node versions Sep 8, 2023
@W-A-James W-A-James marked this pull request as ready for review September 8, 2023 15:50
@nbbeeken nbbeeken self-assigned this Sep 11, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 11, 2023
@nbbeeken nbbeeken merged commit 12d169c into 5.x Sep 11, 2023
@nbbeeken nbbeeken deleted the NODE-5623 branch September 11, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @nbbeeken @durran