Skip to content

fix HybridRelations::belongsToMany not compatible with Model::belongsToMany #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix HybridRelations::belongsToMany not compatible with Model::belongsToMany #1282

wants to merge 3 commits into from

Conversation

akaroot
Copy link

@akaroot akaroot commented Aug 31, 2017

This should fix issue #1273 for Laravel 5.5.
This is incompatible with Laravel < 5.5 so it couldn't be used for v 3.2.*

akaroot added 3 commits August 31, 2017 08:40
@akaroot
fix for Laravel 5.5
066e219 
fix HybridRelations::belongsToMany not compatible with Model::belongsToMany.
This is incompatible with 5.4
@akaroot
update composer for 5.5
31219bd
@akaroot
fix typo
39443d8
This was referenced Aug 31, 2017
Closed
Closed
@jenssegers
Copy link
Contributor

Looks like there are more things broken according to travis.

@dasbit dasbit mentioned this pull request Sep 6, 2017
Closed
@nshelms
Copy link

nshelms commented Sep 6, 2017

I went through the file and updated all of the functions while keeping the composer.json changes as well. Here's a patch file. Can someone tell me if it fixes this?

patch--170906.txt

@eboye eboye mentioned this pull request Sep 10, 2017
Closed
@godfreymakori
Copy link

Check out this gist 066e219

@sagargulati sagargulati mentioned this pull request Sep 19, 2017
Merged
@moiz2050
Copy link

moiz2050 commented Sep 22, 2017 •
edited
Loading

@jenssegers i am still having this issue while installing version 3.2.3 with L5.5

[ErrorException] Declaration of Jenssegers\Mongodb\Eloquent\HybridRelations::belongsToMany($related, $collection = NULL, $foreignKey = NULL, $otherKey = NULL, $relation = NULL) should be compatible with Illuminate\Database\Eloquent\Model::belongsToMany($related, $table = NULL, $foreignPivotKey = NULL, $relatedPivotKey = NULL, $parentKey = NULL, $relatedKey = NULL, $relation = NULL)

alicompu
alicompu reviewed Sep 25, 2017
View reviewed changes
src/Jenssegers/Mongodb/Eloquent/HybridRelations.php Outdated
@@ -204,17 +204,20 @@ public function morphTo($name = null, $type = null, $id = null)
}
}

/**
**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss the slash.

@divine
Copy link
Contributor

divine commented Jan 22, 2020

Should be closed, #1300 already merged

cc @Smolevich

@Smolevich Smolevich closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicompu alicompu alicompu left review comments

@moeen-basra moeen-basra moeen-basra approved these changes

@User39837 User39837 User39837 approved these changes

@medteck medteck medteck approved these changes

Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.