Skip to content

Add L5.5 support #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2017
Merged

Add L5.5 support #1300

merged 3 commits into from
Sep 18, 2017

Conversation

MCMatters
Copy link
Contributor

Please review

@sagargulati
Copy link

All checks passed! Can you update the repository? So that we can pull the new drivers and the repo? @jenssegers

@ghost
Copy link

ghost commented Sep 14, 2017

@sagargulati @jenssegers All checks pass because this just removes lot of assertions from tests, see EmbeddedRelationsTest.php. I'm not sure if this really is the PR we're all hoping for. You can't make things pass the test by simply removing failing assertions.

@MCMatters
Copy link
Contributor Author

@ciruvan I only removed events from dispatcher because there is a new "retrieved" event which cause problems with tests. I didn't work with Mockery, but I saw in @RemiCollin PR how it can be handled. I updated code, thanks to RemiCollin

@sagargulati
Copy link

sagargulati commented Sep 14, 2017

So this is good to go now @MCMatters
Yes, I saw that but a minor bug may help ascertain for a final PR @ciruvan

@SimplyCorey
Copy link

Awesome work dude, thank you.

@ghost
Copy link

ghost commented Sep 15, 2017

@MCMatters nice work, man! if that PR is accepted by @jenssegers, I owe you one!

@ConorWright
Copy link

Good job! I've just upgraded to 5.5 and all I'm waiting on is this. Looking forward to it!

@aashari
Copy link

aashari commented Sep 15, 2017

Thankyou so much @MCMatters this is the solution for all of us, thankyouu... now we're waiting PR accepted by @jenssegers :)

@sagargulati
Copy link

@jenssegers , when should we expect you will accept the PR by @MCMatters ? :)

@jenssegers jenssegers merged commit 5ecbf0b into mongodb:master Sep 18, 2017
@jenssegers jenssegers mentioned this pull request Sep 18, 2017
@sagargulati
Copy link

sagargulati commented Sep 19, 2017

Shouldn't someone update README.md as well? :)
Also still getting an error of Hybrid Relations. Check #1282 @jenssegers?

@MCMatters
Copy link
Contributor Author

@sagargulati where exactly do you have an error?

@sagargulati
Copy link

It's was on belongsToMany. I am using Alpha now and seems it working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants