-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add L5.5 support #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L5.5 support #1300
Conversation
All checks passed! Can you update the repository? So that we can pull the new drivers and the repo? @jenssegers |
@sagargulati @jenssegers All checks pass because this just removes lot of assertions from tests, see EmbeddedRelationsTest.php. I'm not sure if this really is the PR we're all hoping for. You can't make things pass the test by simply removing failing assertions. |
@ciruvan I only removed events from dispatcher because there is a new "retrieved" event which cause problems with tests. I didn't work with Mockery, but I saw in @RemiCollin PR how it can be handled. I updated code, thanks to RemiCollin |
So this is good to go now @MCMatters |
Awesome work dude, thank you. |
@MCMatters nice work, man! if that PR is accepted by @jenssegers, I owe you one! |
Good job! I've just upgraded to 5.5 and all I'm waiting on is this. Looking forward to it! |
Thankyou so much @MCMatters this is the solution for all of us, thankyouu... now we're waiting PR accepted by @jenssegers :) |
@jenssegers , when should we expect you will accept the PR by @MCMatters ? :) |
Shouldn't someone update README.md as well? :) |
@sagargulati where exactly do you have an error? |
It's was on belongsToMany. I am using Alpha now and seems it working fine. |
Add L5.5 support
Please review