Skip to content

CDRIVER-4468 revert additional ccache checks #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2022
Merged

CDRIVER-4468 revert additional ccache checks #1100

merged 2 commits into from
Aug 31, 2022

Conversation

kevinAlbs
Copy link
Collaborator

Summary

Background & Motivation

The changes appear to introduce a regression building on macOS:

-- Found ccache: /usr/local/bin/ccache
ccache: invalid option -- n
CMake Error at build/cmake/CCache.cmake:28 (string):
  string sub-command REGEX, mode MATCH needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:86 (include)

This was noticed during an attempt to prepare a release for 1.23.0. I had not noticed before since I was configuring with MONGO_USE_CCACHE=ON.

This comment has additional details.

The fix is not obvious to me. Since these are improvements intended for stability in Evergreen, I want to revert to unblock the 1.23.0 release for today.

@kevinAlbs kevinAlbs merged commit d078534 into master Aug 31, 2022
@kevinAlbs kevinAlbs deleted the CDRIVER-4468 branch October 20, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants