Do not elide find_package() if MONGO_USE_CCACHE is set

[eramongodb]

Description

Fix overzealous elison of call to find_package() find_program() introduced in #1029 when MONGO_USE_CCACHE is set. CCACHE_EXECUTABLE still needs to be found and set when MONGO_USE_CCACHE is manually set by the user on initial configuration, not just post-configuration.

[vector-of-bool]

I discovered one other quirk of note. Also, I'm guessing you probably meant "find_program()" in the commit/PR message 🙂.

[vector-of-bool]

Is there a reason you're repeating the condition in the endif() call?

[eramongodb]

Just to not lose track of the corresponding if () given the size of the block, a la #endif // COND or } // namespace <name>. I can remove if you think it is undesirable/unnecessary.

[vector-of-bool]

It only tends to be a code smell as it is a very very old pattern that is disrecommended anymore in favor of just using prose-like comments for the purpose, but I don't feel strongly about it here.

[eramongodb]

I prefer endif (<cond>) over endif () # cond since CMake actually detects and enforces <cond> matches, which is a maintainability bonus imo as it prevents (or at least tries to prevent) the possibility of prose-like comments becoming outdated/detached from the matching if ().

CMake Warning (dev) in example/CMakeLists.txt:
  A logical block opening on the line
    CMakeLists.txt:10 (if)
  closes on the line
    CMakeLists.txt:12 (endif)
  with mis-matching arguments.

Admittedly it gets confusing if there are any elseif() / else () blocks involved, so I avoid using it in such cases, but I still prefer using them if it's simple (but large) if() / endif() blocks. I may reconsider this stance after further thought. 🤔

[eramongodb]

I'm guessing you probably meant "find_program()" in the commit/PR message

Fixed it in the commit message in the description, but not in the commit message header itself. 🤦