Skip to content

Remove debug-compile-coverage from Apple LLVM variant #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

eramongodb
Copy link
Contributor

GCOV is sometimes unusually slow on macos-1014, regularly timing out on Evergreen due to taking over 1 hour to parse .gcda files when it should take under 4 minutes. Some .gcda files such as entity-map.c.gcda seem to be culprit, but it is unclear why this behavior seems to only occur on macos-1014 when other coverage tasks take no longer than 10 minutes.

Suggest removing the task rather than diagnosing the issue, as actual difference in code coverage of interest does not seem to be significant across Linux and MacOS (code coverage of different SSL library compatibility backends seems far more significant).

@eramongodb eramongodb requested a review from kevinAlbs January 10, 2023 17:29
@eramongodb eramongodb self-assigned this Jan 10, 2023
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO the debug-compile-coverage task on macOS 10.14 does not provide much value. I agree with removing the task.

@eramongodb eramongodb merged commit 8409087 into mongodb:master Jan 10, 2023
@eramongodb eramongodb deleted the cdriver-coverage branch January 11, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants