CDRIVER-4563 do not create or drop eccCollection
#1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kevinAlbs
force-pushed
the
D2524
branch
2 times, most recently
from
3846611 to
18abd11
Compare
eramongodb
approved these changes
Apr 13, 2023
Comment on lines
1123
to
1124
| "Driver support of Queryable Encryption is incompatible " | ||
| "with server. Upgrade server to use Queryable Encryption."); |
There was a problem hiding this comment.
Suggest including both the detected max wire version and the required server version in the error message.
| @@ -310,6 +310,8 @@ _mongoc_wire_version_to_server_version (int32_t version) | |||
| return "5.3"; | |||
| case 17: | |||
| return "6.0"; | |||
| case 21: | |||
There was a problem hiding this comment.
Suggested change
| case 21: | |
| case WIRE_VERSION_7_0: |
May be worth considering replacing literals here with their macro equivalents.
vector-of-bool
approved these changes
Apr 21, 2023
Co-authored-by: vector-of-bool <[email protected]>
jmikola
reviewed
May 30, 2023
| create_encField_state_collection ( | ||
| database, encryptedFields, name, "ecoc", error); | ||
| if (!state_collections_ok) { | ||
| // Failed to create one or more state collections | ||
| goto fail; | ||
| } | ||
|
|
||
| // Check the wire version to ensure server is 7.0.0 or newer. |
There was a problem hiding this comment.
This wire version check should be performed before creating the QEv2 state collections. I opened CDRIVER-4653 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eccCollection.fle2v2spec tests.Verified with this patch build.
Background & Motivation
See DRIVERS-2524 for additional background behind these changes.