-
Notifications
You must be signed in to change notification settings - Fork 455
CDRIVER-4563 do not create or drop eccCollection
#1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8390b32
format mongoc-collection.c
kevinAlbs 21e3d7c
do not create or drop eccCollection
kevinAlbs 076d164
add wire version macro for 7.0
kevinAlbs 3a87341
add wire version check and test
kevinAlbs b2f86e7
resync fle2v2 tests to aa28f787718eb4306ce7ff8e5a87bd46bb0a2c05
kevinAlbs 876d69b
Merge branch 'master' into D2524
kevinAlbs a7859a7
add actual and expected maxWireVersion
kevinAlbs 435ffcb
use available WIRE_VERSION_* macros
kevinAlbs 9336af6
sync fle2v2 tests to eb3d882bb8c08d0f25f54709abcd876caeccba7f
kevinAlbs 9951fa3
Update src/libmongoc/src/mongoc/mongoc-database.c
kevinAlbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,4 +27,4 @@ | |
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,5 @@ | |
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,4 +26,5 @@ | |
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,5 @@ | |
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,5 @@ | |
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
...libmongoc/tests/json/client_side_encryption/legacy/fle2v2-CreateCollection-OldServer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| { | ||
| "runOn": [ | ||
| { | ||
| "minServerVersion": "6.0.0", | ||
| "maxServerVersion": "6.3.99", | ||
| "topology": [ | ||
| "replicaset", | ||
| "sharded", | ||
| "load-balanced" | ||
| ] | ||
| } | ||
| ], | ||
| "database_name": "default", | ||
| "collection_name": "default", | ||
| "tests": [ | ||
| { | ||
| "description": "driver returns an error if creating a QEv2 collection on unsupported server", | ||
| "clientOptions": { | ||
| "autoEncryptOpts": { | ||
| "kmsProviders": { | ||
| "aws": {} | ||
| }, | ||
| "encryptedFieldsMap": { | ||
| "default.encryptedCollection": { | ||
| "fields": [ | ||
| { | ||
| "path": "firstName", | ||
| "bsonType": "string", | ||
| "keyId": { | ||
| "$binary": { | ||
| "base64": "AAAAAAAAAAAAAAAAAAAAAA==", | ||
| "subType": "04" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "operations": [ | ||
| { | ||
| "name": "dropCollection", | ||
| "object": "database", | ||
| "arguments": { | ||
| "collection": "encryptedCollection" | ||
| } | ||
| }, | ||
| { | ||
| "name": "createCollection", | ||
| "object": "database", | ||
| "arguments": { | ||
| "collection": "encryptedCollection" | ||
| }, | ||
| "result": { | ||
| "errorContains": "Driver support of Queryable Encryption is incompatible with server. Upgrade server to use Queryable Encryption." | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wire version check should be performed before creating the QEv2 state collections. I opened CDRIVER-4653 to track this.