CDRIVER-4694 calculate payload length for kms_request_append_payload() #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an assert failure during MONGODB-AWS auth when an application is bundled with both libmongoc and libmongocrypt, and libmongocrypt's KMS library is used.
jmikola
commented
Jul 18, 2023
| @@ -1242,7 +1242,7 @@ _client_second (mongoc_cluster_t *cluster, | |||
| AUTH_ERROR_AND_FAIL ("Failed to parse server nonce"); | |||
| } | |||
|
|
|||
| if (!kms_request_append_payload (request, body, -1)) { | |||
| if (!kms_request_append_payload (request, body, strlen(body))) { | |||
There was a problem hiding this comment.
@kevinAlbs: I can confirm that this avoids the assertion failure in PHPC. Authentication still fails for other reasons, which I'm investigating, but we do make it beyond this point.
kevinAlbs
pushed a commit
that referenced
this pull request
Jul 18, 2023
#1346) This fixes an assert failure during MONGODB-AWS auth when an application is bundled with both libmongoc and libmongocrypt, and libmongocrypt's KMS library is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CDRIVER-4694
This fixes an assert failure during MONGODB-AWS auth when an application is bundled with both libmongoc and libmongocrypt, and libmongocrypt's KMS library is used.
Note: this is pending test with the PHP driver. I'll follow up once I confirm it resolves the issue.