Skip to content

CDRIVER-4694 calculate payload length for kms_request_append_payload() #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

CDRIVER-4694 calculate payload length for kms_request_append_payload() #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libmongoc/src/mongoc/mongoc-cluster-aws.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,7 @@ _client_second (mongoc_cluster_t *cluster,
AUTH_ERROR_AND_FAIL ("Failed to parse server nonce");
}

if (!kms_request_append_payload (request, body, -1)) {
if (!kms_request_append_payload (request, body, strlen(body))) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinAlbs: I can confirm that this avoids the assertion failure in PHPC. Authentication still fails for other reasons, which I'm investigating, but we do make it beyond this point.

AUTH_ERROR_AND_FAIL ("Failed to append payload");
}

Expand Down