CDRIVER-4350 unskip mock tests and remove unnecessary skips #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of mongodb#1220 the `storeEventsAsEntities` operation is supported in the test runner
Test is already skipped in runner.c
….txt Test is already skipped in runner.c
Test is already skipped in runner.c
rcsanchez97
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially resolves CDRIVER-4350.
Unskip the following mock server tests:
/inheritance/find/readPrefs/BulkOperation/error/unordered/command_monitoring/get_error/Collection/find_with_opts/newoption/inheritance/replace_one/writeConcern/Collection/find_with_opts/newoptionUnskip the following live test:
/unified/entity-client-storeEventsAsEntitiesRemove unnecessary skips for the following tests:
/unified/assertNumberConnectionsCheckedOut/unified/entity-client-cmap-eventsBackground and Motivation
CDRIVER-4350 references both live and mock tests. The following are mock tests:
/inheritance/find/readPrefs/BulkOperation/error/unordered/command_monitoring/get_error/Collection/find_with_opts/newoption/inheritance/replace_one/writeConcern/Collection/find_with_opts/newoptionAs of #1277, mock server tests are only run on ubuntu2204-small distro. The flaky test failures may no longer be applicable. Mock tests were unskipped and run in a patch build: https://spruce.mongodb.com/version/6523f7c20305b90bc8cf1bee The result of three runs was success.
The following live tests were already skipped in runner.c:
/unified/assertNumberConnectionsCheckedOut/unified/entity-client-cmap-events/unified/entity-client-storeEventsAsEntitiesEntries in skip-tests.txt were removed due to unnecessary duplicate skips.
/unified/entity-client-storeEventsAsEntitieswas initially skipped in #820 due to not implementing thestoreEventsAsEntitiesused in the test:#1220 implements the
storeEventsAsEntitiesoperation./unified/entity-client-storeEventsAsEntitiesis unskipped inrunner.c.Unskipping other live referenced tests resulted in an observed test failure in
/change_streams/legacy/change-streams-resume-allowliston this patch and is not addressed in this PR.