Skip to content

CDRIVER-4350 unskip mock tests and remove unnecessary skips #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2023
Merged

CDRIVER-4350 unskip mock tests and remove unnecessary skips #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e21a49
unskip mock tests referenced in CDRIVER-4350
kevinAlbs Oct 9, 2023
274374a
unskip `entity-client-storeEventsAsEntities`
kevinAlbs Oct 9, 2023
e6f1288
remove `/unified/entity-client-cmap-events` from skip-tests.txt
kevinAlbs Oct 9, 2023
4f7c4e2
remove `/unified/entity-client-storeEventsAsEntities` from skip-tests…
kevinAlbs Oct 9, 2023
69d3508
remove `/unified/assertNumberConnectionsCheckedOut` from skip-tests.txt
kevinAlbs Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .evergreen/etc/skip-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,9 @@
/ClientPool/pop_timeout # (CDRIVER-4348) precondition failed: duration_usec / 1000 >= 1990
/Client/get_handshake_hello_response/pooled # (CDRIVER-4349) Assert Failure: "Unknown" != "PossiblePrimary"

/inheritance/find/readPrefs # (CDRIVER-4350) request_matches_msg(): precondition failed: request
/BulkOperation/error/unordered # (CDRIVER-4350) request_matches_msg(): precondition failed: request
/command_monitoring/get_error # (CDRIVER-4350) request_matches_msg(): precondition failed: request
/change_streams/legacy/change-streams # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/change_streams/legacy/change-streams-resume-allowlist # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/change_streams/legacy/change-streams-resume-errorLabels # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/Collection/find_with_opts/newoption # (CDRIVER-4350) request_matches_msg(): precondition failed: request
/inheritance/replace_one/writeConcern # (CDRIVER-4350) request_matches_msg(): precondition failed: request
/Collection/find_with_opts/newoption # (CDRIVER-4350) request_matches_msg(): precondition failed: request
/unified/assertNumberConnectionsCheckedOut # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/unified/entity-client-cmap-events # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/unified/entity-client-storeEventsAsEntities # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/unified/entity-find-cursor # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000']
/change_streams/legacy/change-streams-errors # (CDRIVER-4350) Could not establish stream for node 127.0.0.1:8000: [TLS handshake failed: Connection timed out calling hello on '127.0.0.1:8000'] (on ASAN Tests Ubuntu 18.04 build variant)

Expand Down
2 changes: 0 additions & 2 deletions src/libmongoc/tests/unified/runner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ typedef struct {
skipped_unified_test_t SKIPPED_TESTS[] = {
// CDRIVER-4001, DRIVERS-1781, and DRIVERS-1448: 5.0 cursor behavior
{"poc-command-monitoring", "A successful find event with a getmore and the server kills the cursor"},
// CDRIVER-3867: drivers atlas testing (schema version 1.2)
{"entity-client-storeEventsAsEntities", SKIP_ALL_TESTS},
// libmongoc does not have a distinct helper, so skip snapshot tests testing particular distinct functionality
{"snapshot-sessions", "Distinct operation with snapshot"},
{"snapshot-sessions", "Mixed operation with snapshot"},
Expand Down