Skip to content

Refactor Earthly EVG tasks for better consistency with C Driver tasks #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Jan 26, 2024

Compare task and variant names in this patch vs. base commit.

Notable changes:

  • Grouped all Earthly tasks under a single "earthly" build variant, selected via a single .earthly tag.
  • Prefixed all Earthly task names with earthly- (alphabetically grouped in tasks.yml).
  • Moved platform selection into task name.
  • All task names and fields are lowercase and delimited by simple dashes.
  • Fixed list of earthly-{env} tags per task.
  • Moved run_on field from tasks to build variant (specific distro doesn't matter + reduce tasks.yml verbosity).

Also includes the following drive-by improvements:

@eramongodb eramongodb self-assigned this Jan 26, 2024
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately runs counter to the intended design, that is: Earthly is the means to support additional targets, but it isn't the target itself (e.g. having an "Earthly" build variant is akin to having a "CMake" build variant).

I have changes in progress (soon to be an open PR) that will expand the platform set and capabilities of the Earthly execution, and hope to eventually migrate most CI tasks such that they can be executed this same way.

@eramongodb
Copy link
Contributor Author

Deferring/postponing this PR in favor of prioritizing #1537. May revisit suggestions in this PR later, relative to #1537 instead.

@eramongodb eramongodb closed this Feb 23, 2024
@eramongodb eramongodb deleted the cdriver-earthly branch February 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants