Skip to content

Pin test Docker image to Alpine 3.19 #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

kevinAlbs
Copy link
Collaborator

Summary

Pin test Docker image to Alpine 3.19

This is a follow-up to #1088

Background & Motivation

Motivated by this slack thread.

Using alpine:3.19 may be preferable to alpine:3 to prevent unexpected test failures from Alpine image updates. Pinning to a specific version enables intentional upgrade of the image.

Tested on an Ubuntu 22.04 spawn host:

cd extras/docker/alpine3.19
yes | docker system prune -a
make nocachebuild
make test
# Prints `THE alpine3.19 IMAGE WORKS!`

Attempting to test locally on my arm64 macOS resulted in an error building libmongocrypt fixed in MONGOCRYPT-601. MONGOCRYPT-601 is not yet released.

Copy link
Contributor

@kkloberdanz kkloberdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think that there is merit to always test against the latest Alpine image in CI, i.e., using alpine3 as the base image, I don't have a strong opinion either way, so I'm fine with this too.

@kevinAlbs kevinAlbs merged commit e55e85f into mongodb:master Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants