Skip to content

use CMake 3.29.0 in tests #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

kevinAlbs
Copy link
Collaborator

Summary

Build tests with CMake 3.29.0 to resolve Windows OpenSSL task failures.

Background & Motivation

This PR is intended to address Windows OpenSSL tasks failing to locate OpenSSL. For example, sasl-cyrus-openssl-windows-2019-vs2017-x64-compile fails with:

[2024/03/25 15:11:45.958] CMake Error at C:/Users/mci-exec/AppData/Local/mongo-c-driver/tmp.mwlWImHNJh/cmake-3.25.3-windows-x86_64/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
[2024/03/25 15:11:45.958]   Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
[2024/03/25 15:11:45.958]   system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY) (found
[2024/03/25 15:11:45.958]   version "3.2.1")

This appears to have been caused by a change in the OpenSSL install on Windows hosts to use choco install as part of DEVPROD-5184. Notably, this change results in Windows tasks testing with OpenSSL 3.

I expect the issue is addressed by https://gitlab.kitware.com/cmake/cmake/-/issues/25702. Upgrading CMake to 3.29.0 resolves the issue. Using the previous release, CMake 3.28.4, results in the same error.

Here is a patch build with the sasl-cyrus-openssl-windows-2019-vs2017-x64-compile task passing. There are several other task failures that this PR does not address.

@kevinAlbs kevinAlbs marked this pull request as ready for review March 28, 2024 17:12
@kevinAlbs kevinAlbs requested a review from rcsanchez97 March 28, 2024 17:12
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only someone could come up with some kind of standardized directory structure that different operating systems and different software projects could all agree upon. Maybe some kind of portable operating system standard ...

@kevinAlbs kevinAlbs merged commit d8df329 into mongodb:master Mar 29, 2024
kevinAlbs added a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants