do not link to OpenSSL in MinGW task #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the failing
link-with-cmake-mingw
task (example):Here is a patch build with these changes applied and the task
link-with-cmake-mingw
task passing: https://spruce.mongodb.com/version/660da4c4b9585300076ee2e0This is a follow-up to #1566. Upgrading to CMake 3.29.0 fixed OpenSSL tasks with Visual Studio, but not the MinGW task. The error locating OpenSSL with the MinGW generator was reported to CMake here: https://gitlab.kitware.com/cmake/cmake/-/issues/25859. The response noted:
I am not sure how valuable it is to test linking to OpenSSL when building with MinGW. This PR changes to use ENABLE_SSL=WINDOWS to use Windows Secure Channel to keep test coverage of building with MinGW.