CDRIVER-3877 test BSON string produced #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
commented
Jan 26, 2021
| "1;\" }, \"code_w_scope\" : { \"$code\" : \"var x = 1;\", \"$scope\" : { " | ||
| "} }, \"int32\" : { \"$numberInt\" : \"1\" }, \"timestamp\" : { " | ||
| "\"$timestamp\" : { \"t\" : 2, \"i\" : 3 } }, \"int64\" : { " | ||
| "\"$numberLong\" : \"4\" }, \"decimal128\" : { \"$numberDecimal\" : " |
There was a problem hiding this comment.
This tests the bug at hand, that an int64 produces { "$numberLong": "4" } with the space before }. But it seemed prudent to test JSON produced of all BSON types while adding this.
| @@ -2446,7 +2446,8 @@ test_bson_binary_null_handling (void) | |||
| } | |||
|
|
|||
| static void | |||
| test_bson_append_null_from_utf8_or_symbol (void) { | |||
| test_bson_append_null_from_utf8_or_symbol (void) | |||
| { | |||
kevinAlbs
added a commit
that referenced
this pull request
Feb 1, 2021
chardan
pushed a commit
to chardan/mongo-c-driver
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug fix is part of 4ed2848#diff-40f2bad12fecbb316a142e83953d727ed35c749b920931a18791f8558654aef2R2582
That line will be backported, along with this test, in 1.17.4.