Skip to content

CDRIVER-3877 test BSON string produced #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2021
Merged

CDRIVER-3877 test BSON string produced #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions src/libbson/tests/test-bson.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2446,7 +2446,8 @@ test_bson_binary_null_handling (void)
}

static void
test_bson_append_null_from_utf8_or_symbol (void) {
test_bson_append_null_from_utf8_or_symbol (void)
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang format

bson_t bson;
bson_iter_t iter;

Expand All @@ -2461,6 +2462,46 @@ test_bson_append_null_from_utf8_or_symbol (void) {
bson_destroy (&bson);
}

static void
test_bson_as_json_string (void)
{
bson_t *all_types;
int i;
char *actual;
const char *expected =
"{ \"double\" : { \"$numberDouble\" : \"1.0\" }, \"string\" : "
"\"string_example\", \"document\" : { \"x\" : \"y\" }, \"document\" : [ "
"\"x\" ], \"binary\" : { \"$binary\" : { \"base64\": \"ZGF0YQ==\", "
"\"subType\" : \"00\" } }, \"undefined\" : { \"$undefined\" : true }, "
"\"oid\" : { \"$oid\" : \"000000000000000000000000\" }, \"bool\" : true, "
"\"datetime\" : { \"$date\" : { \"$numberLong\" : \"123\" } }, \"null\" "
": null, \"regex\" : { \"$regularExpression\" : { \"pattern\" : \"a+\", "
"\"options\" : \"\" } }, \"dbpointer\" : { \"$dbPointer\" : { \"$ref\" : "
"\"collection\", \"$id\" : { \"$oid\" : \"000000000000000000000000\" } } "
"}, \"code\" : { \"$code\" : \"var x = 1;\" }, \"symbol\" : { "
"\"$symbol\" : \"symbol_example\" }, \"code\" : { \"$code\" : \"var x = "
"1;\" }, \"code_w_scope\" : { \"$code\" : \"var x = 1;\", \"$scope\" : { "
"} }, \"int32\" : { \"$numberInt\" : \"1\" }, \"timestamp\" : { "
"\"$timestamp\" : { \"t\" : 2, \"i\" : 3 } }, \"int64\" : { "
"\"$numberLong\" : \"4\" }, \"decimal128\" : { \"$numberDecimal\" : "
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests the bug at hand, that an int64 produces { "$numberLong": "4" } with the space before }. But it seemed prudent to test JSON produced of all BSON types while adding this.

"\"1.23456789\" }, \"minkey\" : { \"$minKey\" : 1 }, \"maxkey\" : { "
"\"$maxKey\" : 1 }, \"\" : { \"$numberInt\" : \"-1\" } }";

all_types = bson_with_all_types ();
actual = bson_as_canonical_extended_json (all_types, NULL);

for (i = 0; i < strlen (expected); i++) {
if (expected[i] != actual[i]) {
test_error ("character mismatch at %d. Expected: %s, got %s",
i,
expected,
actual);
}
}

bson_free (actual);
}

void
test_bson_install (TestSuite *suite)
{
Expand Down Expand Up @@ -2555,5 +2596,8 @@ test_bson_install (TestSuite *suite)
test_bson_iter_init_from_data_at_offset);
TestSuite_Add (
suite, "/bson/value/null_handling", test_bson_binary_null_handling);
TestSuite_Add (suite, "/bson/append_null_from_utf8_or_symbol", test_bson_append_null_from_utf8_or_symbol);
TestSuite_Add (suite,
"/bson/append_null_from_utf8_or_symbol",
test_bson_append_null_from_utf8_or_symbol);
TestSuite_Add (suite, "/bson/as_json_string", test_bson_as_json_string);
}