CDRIVER-3773 Support regular expressions with no options #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjirewis this change breaks the bson-corpus test suite in PHP. There is a test that expects a parse error when presented a regular expression without options: https://github.com/mongodb/specifications/blob/master/source/bson-corpus/tests/top.json#L74..L77. I'll skip the test in PHP, but wanted to give you a heads up that this is covered by the corpus. |
|
Apologies for overlooking that test. Looking into how important the change is for python-bsonjs. I'll remove this change no matter what since it's spec-test breaking. If we still want to make the change, I'll do it through a drivers ticket with an actual spec change instead. |
benjirewis
added a commit
that referenced
this pull request
Mar 11, 2021
This reverts commit 2e685d1.
chardan
pushed a commit
to chardan/mongo-c-driver
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDRIVER-3773
python-bsonjs, which relies on libbson, requested the ability to load regexes without the "options" field through JSON into BSON. I see no language in the extended JSON spec forbidding this behavior, and it's unlikely an existing user would actively expect a "missing options" error, so it seems ok to add.
Removes the "missing options" errors in
_bson_json_read_append_regexand adds two new tests to verify correct parsing and absence of error for legacy and canonical regexes without options.