Skip to content

CDRIVER-3773 Remove support for canonical regular expressions with no options #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

benjirewis
Copy link
Contributor

Reverts #751.

We cannot support regular expressions with no options without a spec change because of an existing spec test that checks for a parse error on a regex with no options.

CDRIVER-3773 would require a larger spec change, which I will look into.

@benjirewis benjirewis requested a review from bazile-clyde March 11, 2021 19:31
Copy link
Contributor

@bazile-clyde bazile-clyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd wait for a few of the tests to pass and then merge.

@benjirewis benjirewis requested a review from bazile-clyde March 11, 2021 21:39
@benjirewis benjirewis changed the title Revert "CDRIVER-3773 Support regular expressions with no options" CDRIVER-3773 Remove support for canonical regular expressions with no options Mar 11, 2021
@benjirewis benjirewis merged commit 27f1d6e into master Mar 11, 2021
@benjirewis benjirewis deleted the revert-751-allowNoOptionsRegex.3773 branch March 11, 2021 22:58
chardan pushed a commit to chardan/mongo-c-driver that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants