CDRIVER-3895: Sync CRUD tests for dots/dollars #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced with mongodb/specifications@fc21cb7 Note: this also pulls in test changes relevant to aggregate let support (CDRIVER-4010)
|
@jmikola thanks for the heads up. It seems like this PR will handle the
only thing we need for CDRIVER-4010. Do you think the commit message
for your change should mention CDRIVER-4010, or would it be better for
me to just mention the commit (after the rebase or merge of this PR)
that updates the spec test when closing CDRIVER-4010?
|
@rcsanchez97: I do mention CDRIVER-4010 in the commit message, just not the first line. That's sufficient for the git bot to link it up with CDRIVER-4010 in JIRA. If there were actual code changes for CDRIVER-4010 required, I'd be inclined to mention it in the first line, but I think what we have now is fine considering it's just spec tests. |
|
Thanks for pointing that out. I missed the ticket reference because it
wasn't on the first line. I don't think that moving it to the first
line is necessary as long as the commit gets linked into Jira.
|
chardan
pushed a commit
to chardan/mongo-c-driver
that referenced
this pull request
Aug 26, 2021
…odb#809) * Fix CXX-2329; change type of thrown exception to match documentation. Modify exceptions throw to use mongocxx::logic_error. Adds std::error_code/std::errc plumbing, as mongocxx::exception derives from std::system_exception, and mongocxx::logic_error derives in turn from that. See: https://jira.mongodb.org/browse/CXX-2329 Signed-off-by: Jesse Williamson <[email protected]> * Updated thrown type to use mongocxx error codes. We provide our own error codes, and there's precedent for using k_invalid_argument. Signed-off-by: Jesse Williamson <[email protected]> * Added new mongocxx::error_code for failing to create a resource. Signed-off-by: Jesse Williamson <[email protected]> * Throw mongocxx::logic_error rather than std::logic_error. Signed-off-by: Jesse Williamson <[email protected]> * clang-format Signed-off-by: Jesse Williamson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CDRIVER-3895
Synced with mongodb/specifications@fc21cb7 (see mongodb/specifications#1028 for more context).
Note: this also pulls in test changes relevant to aggregate let support (CDRIVER-4010)
@rcsanchez97: The previous PR for CDRIVER-3895 (#801) introduced
aggregate-let.jsonand this PR pulls in the latest updates from mongodb/specifications@3a58fc6. Per @kevinAlbs' comment in CDRIVER-4010 there may be no other work required for that ticket (perhaps beyond documentation if applicable) if the spec tests currently pass.