CDRIVER-4010 support 'let' option for aggregate command #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jun 28, 2021
kevinAlbs
requested changes
Jun 28, 2021
There was a problem hiding this comment.
Oops, I reviewed this before looking at #809. The test resync will be part of that PR.
Can you additionally update the documentation pages:
- http://mongoc.org/libmongoc/current/mongoc_database_aggregate.html
- http://mongoc.org/libmongoc/current/mongoc_collection_aggregate.html
To note the new option?
|
Sure. I am guessing that I will also need to drop the test sync since
#809 handled that.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full patch build: https://spruce.mongodb.com/version/60d5ee4be3c33111e05b9faa/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
I checked quite a few of the failures in that patch build in every single case (with one exception*) the failure in the patch build was identical to the failure of the same task in the base commit. *The one exception is a Valgrind test that had a hard failure in the base commit but which timed out in the patch build.
Based on this, it seems like the C driver already has the necessary support, so simply updating the CRUD JSON test is all we need to do.