CDRIVER-4309: always use count command for estimatedDocumentCount #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced with mongodb/specifications@021cbc8 Includes some test changes for CDRIVER-4063 and CDRIVER-4330
This requires setting MONGOC_ERROR_API_VERSION_2 on clients under test. It was previously only set on the internal client.
|
Looks good, other than the newly failing |
jmikola
commented
May 6, 2022
| @@ -2502,7 +2501,7 @@ test_estimated_document_count (void) | |||
| collection, tmp_bson ("{'limit': 2, 'skip': 1}"), NULL, &reply, &error); | |||
|
|
|||
| request = mock_server_receives_msg ( | |||
| server, 0, tmp_bson ("{'aggregate': 'coll', 'limit': 2, 'skip': 1}")); | |||
| server, 0, tmp_bson ("{'count': 'coll', 'limit': 2, 'skip': 1}")); | |||
There was a problem hiding this comment.
@vector-of-bool: Thanks for catching this.
|
Latest build shows task failures consistent with the base commit (nothing new after restarting the ASAN Ubuntu 18.04 builds), so I think we're good to merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CDRIVER-4309
Related to #982, but I believe this can be merged first.