CDRIVER-4199: Add support for the comment field to all helpers #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
cdriver-4199
branch
2 times, most recently
from
294818c to
5c959d1
Compare
jmikola
commented
May 4, 2022
kevinAlbs
reviewed
May 6, 2022
kevinAlbs
approved these changes
May 11, 2022
vector-of-bool
approved these changes
May 11, 2022
Sync unified change stream and CRUD tests with mongodb/specifications@b8371ea Comment option for bulkWrite, insert, update, delete, findAndModify, aggregate, and change stream operations. Attach cursor comment to getMore for MongoDB 4.4+ Surface entity_map_match error if expectResult fails. The entity_map_match error contains relevant information about the failed match (e.g. field path). This is consistent with error reporting for error.expectResult later in the function. Update server doc links for database, collection, index enumeration. Also moves the retryable reads include for listDatabases to be consistent with other pages. Use BSON_ASSERT_PARAM for non-null parameter assertions in mongoc-bulk-operation.c. Co-authored-by: Kevin Albertson <[email protected]>
|
@kevinAlbs: Can you help me discern the actual build failure in debug-compile-nosasl-winssl? This is the only task whose build status is inconsistent with the base commit in https://spruce.mongodb.com/version/627db0e361837d34963b517d/tasks. Edit: just to follow-up, the build failure was unrelated so I proceeded with merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CDRIVER-4199
https://jira.mongodb.org/browse/CDRIVER-4374