Skip to content

CSHARP-4429: Support resultSerializer = null in MongoQueryable.AppendStage #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

BorisDog
Copy link
Contributor

No description provided.

@BorisDog BorisDog requested a review from JamesKovacs November 24, 2022 20:24
{
var collection = CreateProductsCollection();
var textStage = "{ $match : { $text : { $search : 'apples' } } }";
var resultSerializer = collection.DocumentSerializer;
var resultSerializer = resultSerializerExists ? collection.DocumentSerializer : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we often use a name like useResultSerializer for a test method parameter that says whether to use a result serializer or not, but the naming is pretty flexible.

@BorisDog BorisDog requested a review from rstam November 24, 2022 21:04
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BorisDog BorisDog merged commit f75c1fb into mongodb:master Nov 24, 2022
dnickless pushed a commit to dnickless/mongo-csharp-driver that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants