Skip to content

CSHARP-4429: Support resultSerializer = null in MongoQueryable.AppendStage #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2022
Merged

CSHARP-4429: Support resultSerializer = null in MongoQueryable.AppendStage #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca18147
CSHARP-4429: Support resultSerializer = null in MongoQueryable.Append…
BorisDog Nov 24, 2022
5217955
- PR comments
BorisDog Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MongoDB.Driver/Linq/MongoQueryable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public static IMongoQueryable<TResult> AppendStage<TSource, TResult>(
GetMethodInfo(AppendStage, source, stage, resultSerializer),
Expression.Convert(source.Expression, typeof(IMongoQueryable<TSource>)),
Expression.Constant(stage),
Expression.Constant(resultSerializer)));
Expression.Constant(resultSerializer, typeof(IBsonSerializer<TSource>))));
}

/// <summary>
Expand Down
8 changes: 5 additions & 3 deletions tests/MongoDB.Driver.Tests/Linq/Linq3ImplementationTests/Jira/CSharp4234Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,21 @@
using System.Linq;
using FluentAssertions;
using MongoDB.Bson;
using MongoDB.Bson.TestHelpers.XunitExtensions;
using MongoDB.Driver.Linq;
using Xunit;

namespace MongoDB.Driver.Tests.Linq.Linq3ImplementationTests.Jira
{
public class CSharp4234Tests : Linq3IntegrationTest
{
[Fact]
public void AppendStage_should_work()
[Theory]
[ParameterAttributeData]
public void AppendStage_should_work([Values(false, true)] bool useResultSerializer)
{
var collection = CreateProductsCollection();
var textStage = "{ $match : { $text : { $search : 'apples' } } }";
var resultSerializer = collection.DocumentSerializer;
var resultSerializer = useResultSerializer ? collection.DocumentSerializer : null;

var queryable = collection
.AsQueryable()
Expand Down