CXX-3008 Add post-release instructions for Silk, Snyk, and patch release tags #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snyk support ticket for mnmlstc/core detection support has been submitted. |
kevinAlbs
reviewed
Jun 17, 2024
kevinAlbs
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional steps following creation of a new release branch
releases/vX.Yto ensure Silk and Snyk are aware of, and continue analyzing, the release branch.Silk commands defer to scripts in the C Driver introduced by mongodb/mongo-c-driver#1619 to minimize redundancy. The CXX Driver will ideally adopt and reuse the same scripts as those used by libmongocrypt and the C Driver.
Snyk commands use the changes proposed in mongodb/libmongocrypt#820 as reference. Note: Snyk does not appear to be able to detect the mnmlstc/core library despite
--detection-depth, so a Snyk support ticket may be necessary.Additionally, a new "merge back into
master" branch is added to release instructions to ensure patch release tags are reachable from the latest commit inmaster. This enables support for accurategit describe --tagsresults as is used by Coverity nightly snapshot labels, abi-compliance-checker HTML compatibility reports, and eventually thecalc_release_version.pyscript (significant simplifications incoming). This step is not expected to affect the current implementation ofcalc_release_version.py: it should continue to return the correct latest tag as intended.