Skip to content

CXX-3008 Improve Silk/Snyk post-release instructions with explicit commands #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

eramongodb
Copy link
Contributor

Followup to #1148 and related to mongodb/mongo-c-driver#1647. Improves release instructions and commands following attempts to create a Silk asset group and Snyk project for the current releases/v3.10 branch.

@eramongodb eramongodb requested a review from kevinAlbs June 18, 2024 18:41
@eramongodb eramongodb self-assigned this Jun 18, 2024
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also added the branch suffix in libmongocrypt to more easily distinguish the Silk project in the web UI.

@eramongodb
Copy link
Contributor Author

After some discussion, added a version number suffix to --project (corresponding to the "name" field, aka the "Asset Group Name"; not to be confused with the "project_name" field) to be able to easily distinguish branch-based asset groups in Silk UI.

@eramongodb eramongodb merged commit b78767d into mongodb:master Jun 18, 2024
1 check was pending
@eramongodb eramongodb deleted the cxx-3008 branch June 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants