GODRIVER-2277 Remove causal consistency prose test #10 (#879)

* GODRIVER-2277 Remove causal consistency prose test #10

* GODRIVER-2277 Remove causal consistency prose test no. 10

* add unack writes subtest to TestSessions

* couple assertion and msg

* use non-verbose error handling

* allow error reassignment

* make assert msg more verbose

* clean up assert msg

Author: prestonvasquez

mongo/integration/causal_consistency_test.go

@@ -17,7 +17,6 @@ import (
 	"go.mongodb.org/mongo-driver/mongo/integration/mtest"
 	"go.mongodb.org/mongo-driver/mongo/options"
 	"go.mongodb.org/mongo-driver/mongo/readconcern"
-	"go.mongodb.org/mongo-driver/mongo/writeconcern"
 )
 
 // set of operations that support read concerns taken from read/write concern spec.
@@ -193,21 +192,6 @@ func TestCausalConsistency_Supported(t *testing.T) {
 		assert.NotNil(mt, sentOptime, "expected operation time on command, got nil")
 		assert.True(mt, currOptime.Equal(*sentOptime), "expected operation time %v, got %v", currOptime, sentOptime)
 	})
-	unackWcOpts := options.Collection().SetWriteConcern(writeconcern.New(writeconcern.W(0)))
-	mt.RunOpts("unacknowledged write", mtest.NewOptions().CollectionOptions(unackWcOpts), func(mt *mtest.T) {
-		// unacknowledged write should not update the operationTime of a session
-
-		sess, err := mt.Client.StartSession()
-		assert.Nil(mt, err, "StartSession error: %v", err)
-		defer sess.EndSession(context.Background())
-
-		_ = mongo.WithSession(context.Background(), sess, func(sc mongo.SessionContext) error {
-			_, _ = mt.Coll.InsertOne(sc, bson.D{{"x", 1}})
-			return nil
-		})
-		optime := sess.OperationTime()
-		assert.Nil(mt, optime, "expected operation time nil, got %v", optime)
-	})
 	mt.Run("clusterTime included", func(mt *mtest.T) {
 		// $clusterTime should be included in commands if the deployment supports cluster times
 

mongo/integration/sessions_test.go

@@ -20,6 +20,7 @@ import (
 	"go.mongodb.org/mongo-driver/mongo/integration/mtest"
 	"go.mongodb.org/mongo-driver/mongo/options"
 	"go.mongodb.org/mongo-driver/mongo/readpref"
+	"go.mongodb.org/mongo-driver/mongo/writeconcern"
 	"go.mongodb.org/mongo-driver/x/mongo/driver/session"
 )
 
@@ -341,6 +342,22 @@ func TestSessions(t *testing.T) {
 			assertCollectionCount(mt, int64(numDocs))
 		})
 	})
+
+	unackWcOpts := options.Collection().SetWriteConcern(writeconcern.New(writeconcern.W(0)))
+	mt.RunOpts("unacknowledged write", mtest.NewOptions().CollectionOptions(unackWcOpts), func(mt *mtest.T) {
+		// unacknowledged write during a session should result in an error
+		sess, err := mt.Client.StartSession()
+		assert.Nil(mt, err, "StartSession error: %v", err)
+		defer sess.EndSession(context.Background())
+
+		err = mongo.WithSession(context.Background(), sess, func(sc mongo.SessionContext) error {
+			_, err := mt.Coll.InsertOne(sc, bson.D{{"x", 1}})
+			return err
+		})
+
+		assert.Equal(mt, err, mongo.ErrUnacknowledgedWrite,
+			"expected ErrUnacknowledgedWrite on unacknowledged write in session, got %v", err)
+	})
 }
 
 func assertCollectionCount(mt *mtest.T, expectedCount int64) {