GODRIVER-2277 Remove causal consistency prose test #10 #879
Conversation
| @@ -193,21 +192,6 @@ func TestCausalConsistency_Supported(t *testing.T) { | |||
| assert.NotNil(mt, sentOptime, "expected operation time on command, got nil") | |||
| assert.True(mt, currOptime.Equal(*sentOptime), "expected operation time %v, got %v", currOptime, sentOptime) | |||
| }) | |||
| unackWcOpts := options.Collection().SetWriteConcern(writeconcern.New(writeconcern.W(0))) | |||
| mt.RunOpts("unacknowledged write", mtest.NewOptions().CollectionOptions(unackWcOpts), func(mt *mtest.T) { | |||
There was a problem hiding this comment.
Just curious, in what situations does this test fail? It does not fail locally for me against a 5.0 replica set.
do we want to tweak the test to assert that doing an unacknowledged write within a session results in an error?
If this is client-side error (thrown within the driver), then that could be a valuable test. If the server just doesn't support unacknowledged writes with explicit sessions, then I don't think we need to test that behavior on our side.
There was a problem hiding this comment.
The test should fail if the 0-number write concern being sent over the wire is acknowledged, which should request[s] no acknowledgment of the write operation.
The error itself is thrown by the *mongo.Collection.InsertOne method, specifically whenever the wire message flag is moreToCome. I can see how we determine this message from the code base, but have no idea why the relationship between unacknowledged writes and moreToCome is 1-1. The server does not explicitly create an error for this and it is technically recommended behavior.
…thub.com:prestonvasquez/mongo-go-driver into GODRIVER-2277.removeCausalConsistencyProseTest10
| @@ -193,21 +192,6 @@ func TestCausalConsistency_Supported(t *testing.T) { | |||
| assert.NotNil(mt, sentOptime, "expected operation time on command, got nil") | |||
| assert.True(mt, currOptime.Equal(*sentOptime), "expected operation time %v, got %v", currOptime, sentOptime) | |||
| }) | |||
| unackWcOpts := options.Collection().SetWriteConcern(writeconcern.New(writeconcern.W(0))) | |||
| mt.RunOpts("unacknowledged write", mtest.NewOptions().CollectionOptions(unackWcOpts), func(mt *mtest.T) { | |||
prestonvasquez
deleted the
GODRIVER-2277.removeCausalConsistencyProseTest10
branch
GODRIVER-2277
Prose Test no. 10 in the Causal Consistency Specification, to validate
niloperation time when executed in a client session, is outdated per SPEC-1019 which "prohibit[s] unack'd writes in a session".The work to implement the change in SPEC-1019 for the GODRIVER team was completed by the work done on GODRIVER-52, specifically with PR#77.
Add a
TestSessionssubtest to ensure that mongo-go-driver errors on unacknowledged writes (i.e. a0-number write concern) during a session.Question(s)